Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce warnings in tests #1502

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Reduce warnings in tests #1502

merged 2 commits into from
Feb 6, 2025

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Feb 5, 2025

Change Summary

Reduces warnings in tests by explicitly setting flags to enable new iris functionality.

Related issue number

closes #1490
related to #1066

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.51%. Comparing base (e478075) to head (29d8214).
Report is 99 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1502   +/-   ##
=========================================
  Coverage     78.50%   78.51%           
=========================================
  Files           140      140           
  Lines         21285    21291    +6     
=========================================
+ Hits          16710    16716    +6     
  Misses         4575     4575           
Flag Coverage Δ
unittests 78.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl marked this pull request as ready for review February 5, 2025 12:00
@lewisblake lewisblake added this to the m2025-02 milestone Feb 6, 2025
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦾

@lewisblake lewisblake merged commit 962301d into main-dev Feb 6, 2025
8 checks passed
@lewisblake lewisblake deleted the test-warnings branch February 6, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up warnings coming from Iris in logs
2 participants