Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct types for webdisp_opts #1498

Merged
merged 1 commit into from
Jan 30, 2025
Merged

correct types for webdisp_opts #1498

merged 1 commit into from
Jan 30, 2025

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Jan 30, 2025

Change Summary

title. noticed when running obs-only

Related issue number

NA

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.46%. Comparing base (c972234) to head (5b69097).
Report is 4 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/aeroval/experiment_processor.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1498   +/-   ##
=========================================
  Coverage     78.46%   78.46%           
=========================================
  Files           139      139           
  Lines         21124    21124           
=========================================
  Hits          16575    16575           
  Misses         4549     4549           
Flag Coverage Δ
unittests 78.46% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake added this to the m2025-02 milestone Jan 30, 2025
@lewisblake lewisblake marked this pull request as ready for review January 30, 2025 13:18
Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥘

@lewisblake lewisblake merged commit ce754a6 into main-dev Jan 30, 2025
7 of 8 checks passed
@thorbjoernl thorbjoernl deleted the obs-only-dabble branch January 31, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants