Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aeroval configurations to be run on CI #1403

Draft
wants to merge 1 commit into
base: main-dev
Choose a base branch
from

Conversation

jgriesfeller
Copy link
Member

@jgriesfeller jgriesfeller commented Nov 12, 2024

Change Summary

add small aeroval configurations to pyaerocom.aeroval.config.ciconfigs

Related issue number

fix #926

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@jgriesfeller jgriesfeller self-assigned this Nov 12, 2024
@jgriesfeller jgriesfeller linked an issue Nov 12, 2024 that may be closed by this pull request
@jgriesfeller jgriesfeller added the missing-tests Label associated with missing test coverage label Nov 12, 2024
@jgriesfeller jgriesfeller added this to the m2024-12 milestone Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 78.47%. Comparing base (38a6cf2) to head (8bb94e9).
Report is 6 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/aeroval/config/ciconfigs/base_config.py 0.00% 28 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1403      +/-   ##
============================================
- Coverage     78.58%   78.47%   -0.11%     
============================================
  Files           137      138       +1     
  Lines         20883    20911      +28     
============================================
  Hits          16410    16410              
- Misses         4473     4501      +28     
Flag Coverage Δ
unittests 78.47% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing-tests Label associated with missing test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add test for working aeroval diurnal cycle analysis to CI
1 participant