Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows using more recent versions of numpy #1396

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Allows using more recent versions of numpy #1396

merged 5 commits into from
Nov 14, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Nov 7, 2024

Change Summary

Makes changes required for pyaerocom to work with numpy>=2.0.0

Related issue number

closes #1206

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (974cc33) to head (5465d23).
Report is 69 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/io/gaw/reader.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1396   +/-   ##
=========================================
  Coverage     78.56%   78.56%           
=========================================
  Files           137      137           
  Lines         20921    20905   -16     
=========================================
- Hits          16436    16424   -12     
+ Misses         4485     4481    -4     
Flag Coverage Δ
unittests 78.56% <91.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl marked this pull request as ready for review November 12, 2024 08:30
Copy link
Member

@heikoklein heikoklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@heikoklein heikoklein merged commit 7d8c517 into main-dev Nov 14, 2024
8 checks passed
@heikoklein heikoklein deleted the numpy branch November 14, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyaerocom ValueError when running with numpy 2.0.0
2 participants