Skip to content

Feat/get all #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lakorthus merged 6 commits into from
Jul 6, 2023
Merged

Feat/get all #16

Lakorthus merged 6 commits into from
Jul 6, 2023

Conversation

@Lakorthus
Copy link
Contributor

@Lakorthus Lakorthus commented Jul 6, 2023

What

  • Added route to get ll bids
  • Added Exception on bid_controller when data cannot be retrieved
  • Added test suite

How to review

  • Follow Swagger spec for get all bids
  • Run pytest

Who can review

@methods/accessforce

piratejas
piratejas approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@piratejas piratejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Lakorthus Lakorthus merged commit 918d4e9 into develop Jul 6, 2023
@Lakorthus Lakorthus deleted the feat/get_all branch July 6, 2023 13:44
@Lakorthus Lakorthus mentioned this pull request Jul 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@piratejas piratejas piratejas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lakorthus @piratejas