Trace filters get additional parameter with method/sub name #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Let's extend our two existing filters to write like this. |
| if(typesToStrip.length > 0 && !strippedTypes[type]) | ||
| return data; | ||
|
|
||
| if(receiverType && receiverType!=info.type) |
|
This is pretty solid. Add this to |
roonyh
force-pushed
the
method-sub-filters
branch
from
8810529
to
873ab66
Compare
|
@arunoda, Added to |
|
Did you add(or update) test cases for those changes? |
|
Yes. Added here |
|
Okay great. I'll take these in and do a release. |
arunoda
added a commit
that referenced
this pull request
Oct 30, 2015
Trace filters get additional parameter with method/sub name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.