Fix some linting complaints

meteor · Nov 9, 2019 · 9e60a75 · 9e60a75
1 parent 1cff802
commit 9e60a75
Show file tree

Hide file tree

Showing 10 changed files with 29 additions and 22 deletions.
diff --git a/imports/api/lists/lists.js b/imports/api/lists/lists.js
@@ -1,3 +1,4 @@
+/* eslint-disable import/no-cycle */
 import { Mongo } from 'meteor/mongo';
 import { SimpleSchema } from 'meteor/aldeed:simple-schema';
 import { Factory } from 'meteor/factory';
@@ -25,6 +26,7 @@ class ListsCollection extends Mongo.Collection {
 
     return super.insert(ourList, callback);
   }
+
   remove(selector, callback) {
     Todos.remove({ listId: selector });
     return super.remove(selector, callback);

diff --git a/imports/api/lists/lists.tests.js b/imports/api/lists/lists.tests.js
@@ -9,7 +9,13 @@ import { _ } from 'meteor/underscore';
 import { DDP } from 'meteor/ddp-client';
 
 import { Lists } from './lists.js';
-import { insert, makePublic, makePrivate, updateName, remove } from './methods.js';
+import {
+  insert,
+  makePublic,
+  makePrivate,
+  updateName,
+  remove,
+} from './methods.js';
 import { Todos } from '../todos/todos.js';
 import '../../../i18n/en.i18n.json';
 

diff --git a/imports/api/todos/incompleteCountDenormalizer.js b/imports/api/todos/incompleteCountDenormalizer.js
@@ -1,3 +1,4 @@
+/* eslint-disable import/no-cycle */
 import { _ } from 'meteor/underscore';
 import { check } from 'meteor/check';
 
@@ -31,7 +32,7 @@ const incompleteCountDenormalizer = {
   // Here we need to take the list of todos being removed, selected *before* the update
   // because otherwise we can't figure out the relevant list id(s) (if the todo has been deleted)
   afterRemoveTodos(todos) {
-    todos.forEach(todo => this._updateList(todo.listId));
+    todos.forEach((todo) => this._updateList(todo.listId));
   },
 };
 

diff --git a/imports/api/todos/todos.js b/imports/api/todos/todos.js
@@ -1,3 +1,4 @@
+/* eslint-disable import/no-cycle */
 import { Mongo } from 'meteor/mongo';
 import { Factory } from 'meteor/factory';
 import faker from 'faker';
@@ -14,11 +15,13 @@ class TodosCollection extends Mongo.Collection {
     incompleteCountDenormalizer.afterInsertTodo(ourDoc);
     return result;
   }
+
   update(selector, modifier) {
     const result = super.update(selector, modifier);
     incompleteCountDenormalizer.afterUpdateTodo(selector, modifier);
     return result;
   }
+
   remove(selector) {
     const todos = this.find(selector).fetch();
     const result = super.remove(selector);

diff --git a/imports/ui/components/LanguageToggle.jsx b/imports/ui/components/LanguageToggle.jsx
@@ -36,7 +36,7 @@ const LanguageToggle = () => {
               key={language}
               href="#toggle-language"
               className="language"
-              onClick={event => setI18nLocale(event, language)}
+              onClick={(event) => setI18nLocale(event, language)}
             >
               {language}
             </a>

diff --git a/imports/ui/components/UserMenu.jsx b/imports/ui/components/UserMenu.jsx
@@ -26,11 +26,12 @@ const UserMenu = ({
             : <span className="icon-arrow-down" />}
           {emailLocalPart}
         </a>
-        {open ?
-          <a className="btn-secondary" onClick={logout}>
-            {i18n.__('components.userMenu.logout')}
-          </a> :
-          null}
+        {open
+          ? (
+            <a className="btn-secondary" onClick={logout}>
+              {i18n.__('components.userMenu.logout')}
+            </a>
+          ) : null}
       </div>
     );
   };

diff --git a/imports/ui/pages/ListPage.jsx b/imports/ui/pages/ListPage.jsx
@@ -4,7 +4,7 @@ import i18n from 'meteor/universe:i18n';
 
 import ListHeader from '../components/ListHeader.jsx';
 import TodoItem from '../components/TodoItem.jsx';
-import NotFoundPage from '../pages/NotFoundPage.jsx';
+import NotFoundPage from './NotFoundPage.jsx';
 import Message from '../components/Message.jsx';
 import Loading from '../components/Loading.jsx';
 
@@ -36,7 +36,7 @@ const ListPage = ({
       />
     );
   } else {
-    Todos = todos.map(todo => (
+    Todos = todos.map((todo) => (
       <TodoItem
         todo={todo}
         key={todo._id}

diff --git a/imports/ui/state/GlobalStateProvider.jsx b/imports/ui/state/GlobalStateProvider.jsx
@@ -4,12 +4,9 @@ import PropTypes from 'prop-types';
 import { LocaleProvider } from './LocaleState.jsx';
 import { MenuOpenProvider } from './MenuOpenState.jsx';
 
-export const GlobalStateProvider = ({
-  menuOpen,
-  ...props
-}) => (
+export const GlobalStateProvider = ({ menuOpen }) => (
   <LocaleProvider>
-    <MenuOpenProvider menuOpen={menuOpen} {...props} />
+    <MenuOpenProvider menuOpen={menuOpen} />
   </LocaleProvider>
 );
 

diff --git a/imports/ui/state/LocaleState.jsx b/imports/ui/state/LocaleState.jsx
@@ -19,10 +19,10 @@ const useLocale = () => {
   return context;
 };
 
-const LocaleProvider = (props) => {
+const LocaleProvider = () => {
   const value = useState(defaultLocale);
 
-  return <LocaleContext.Provider value={value} {...props} />;
+  return <LocaleContext.Provider value={value} />;
 };
 
 export { LocaleProvider, useLocale };
diff --git a/imports/ui/state/MenuOpenState.jsx b/imports/ui/state/MenuOpenState.jsx
@@ -17,13 +17,10 @@ const useMenuOpen = () => {
   return context;
 };
 
-const MenuOpenProvider = ({
-  menuOpen: initMenuOpen,
-  ...props
-}) => {
+const MenuOpenProvider = ({ menuOpen: initMenuOpen }) => {
   const value = useState(initMenuOpen);
 
-  return <MenuOpenContext.Provider value={value} {...props} />;
+  return <MenuOpenContext.Provider value={value} />;
 };
 
 MenuOpenProvider.propTypes = {