Concurrency issue with use find client#423
Closed
PedroMarianoAlmeida wants to merge 3 commits intometeor:tests-3.xfrom
Closed
Concurrency issue with use find client#423PedroMarianoAlmeida wants to merge 3 commits intometeor:tests-3.xfrom
PedroMarianoAlmeida wants to merge 3 commits intometeor:tests-3.xfrom
Conversation
268e6c6 to
3743be2
Compare
Contributor
Author
Member
|
@PedroMarianoAlmeida: Sorry, 🙏. When I merged and deleted tests-3.x branch your PR based on that branch closed automatically. Could you reopen the PR with the same contents and ensure to get latest master on it? We have also included CI checks #424 |
Contributor
Author
|
Sure! I will! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Possible fix for #418
I created a new test that failed for the current
useFindand passed for the new oneI basically removed the
useRefand move the Initial Fetch into the Effect, this broke the Verify reference stability between rerenders test so I needed to update therefreshaction onuseFindReducerto compare the values properly (I feel that there is room from improvement on this part).