Reinstate the mongo-dev-server package (#8853) #8999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only start the MongoDB server if this package is present in the project. This reverts commit 565281e.
abernix
approved these changes
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only start the MongoDB server if this package is present in the project.
This reverts commit 565281e.
In addition to re-instating the
mongo-dev-serverchanges, this PR also includes adjustments to thestatic-html - throws errorself-test, that are required as part of themongo-dev-serverwork. These adjustments were orginally included in 4d37a05, but when some of these changes were reverted by 565281e, thestatic-html - throws errorfix was left in 1.5.2. Without the rest of themongo-dev-serverchanges in place howerver, this self-test fix had to be changed, which was done in 22e86ce. Long story short - now that we're adding themongo-dev-serverchanges back into 1.5.2, we have to apply thestatic-html - throws errorchanges again.Also - the
modules - test appself-test failure here is related to the work done in #8963, and is still being investigated (#8913 (comment)). It isn't caused by the changes in this PR.Thanks!