-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.3.4.3 #7369
Merged
Merged
Release 1.3.4.3 #7369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@benjamn is there a chance of releasing another If a release not require any complex merging, of course. |
@kachkaev of course! I haven't even rebased https://github.com/meteor/meteor/tree/release-1.4 against these changes yet :) |
The 0.6.17 version was already taken by another branch, though I'm not sure which one.
With the simultaneous development of Meteor 1.4, npm-bcrypt@0.8.7 has already been published, but we very much do not want to use that version with Meteor 1.3.4.3, since it doesn't work with Node 0.10.46.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the following claim in the release notes for the 1.3.4.2 release was not entirely true:
meteor node
andmeteor npm
commands now respect.meteor/release
when resolving which versions ofnode
andnpm
to invoke. Note that you mustmeteor update
to 1.3.4.2 before this logic will take effect, but it will work in all app directories after updating, even those pinned to older versions. #7338Specifically, running
meteor update
to update to 1.3.4.2 was not actually enough to modify the~/.meteor/meteor
symlink (orAppData\Local\.meteor\meteor.bat
on Windows), which prevented the new behavior ofmeteor node
andmeteor npm
from taking effect.Thanks to @rhettlivingston for providing quick feedback on these concerns!