You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 29, 2021. It is now read-only.
As per meteor/meteor#8648 I discovered a problem with the websocket-driver package used by faye-websocket. It was causing an assert in debug builds of node, and there is a chance that it also results in some form of memory corruption on refresh - though it is hard to say for certain.
The websocket-driver code has been updated to use a new http parser and avoid using node internals. So this feature request is a placeholder to make sure it gets updated when the faye-websocket/websocket-driver gets released.
I have manually dropped in replacements and it seems to work in meteor, but I'm unable to reproduce the crashes that others are seeing so I can't be certain whether it fixes meteor/meteor#8648
The text was updated successfully, but these errors were encountered:
Thanks @sdarnell - I've marked this as pull-requests-encouraged. If anyone is interested in working on this, please wait until after the changes from faye/websocket-driver-node#21 have been published and made available via a new faye-websocket release.
benjamn
pushed a commit
to meteor/meteor
that referenced
this issue
Aug 7, 2017
As per meteor/meteor#8648 I discovered a problem with the websocket-driver package used by faye-websocket. It was causing an assert in debug builds of node, and there is a chance that it also results in some form of memory corruption on refresh - though it is hard to say for certain.
The websocket-driver code has been updated to use a new http parser and avoid using node internals. So this feature request is a placeholder to make sure it gets updated when the faye-websocket/websocket-driver gets released.
See faye/websocket-driver-node#21
I have manually dropped in replacements and it seems to work in meteor, but I'm unable to reproduce the crashes that others are seeing so I can't be certain whether it fixes meteor/meteor#8648
The text was updated successfully, but these errors were encountered: