Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] React Komposer instead of mixins #8

Closed
wants to merge 2 commits into from

Conversation

xavxyz
Copy link

@xavxyz xavxyz commented Jul 17, 2016

I found a way to use react-komposer dynamically with DocumentContainer & ListContainer, tested it in practice on Nova.

After reading different issues & discussions, in order to fit more with the react way,I defined component as a required props, so there is now only one-way to "contain": <Container component={MyDumbComp} />.

I'm having some issues with the infinite scrolling, the whole list re-renders. I guess it's related to arunoda/react-komposer#2 & arunoda/react-komposer#4, maybe it'll be fixed with arunoda/react-komposer#99.

Any feedback welcomed 👍

@SachaG
Copy link
Contributor

SachaG commented Jul 18, 2016

Should we merge it now or wait for the fix? Is the issue just with infinite scrolling or with any type of pagination?

@xavxyz
Copy link
Author

xavxyz commented Jul 19, 2016

We should wait a little, in fact it maybe also related to the way I handle the loading component (doc: https://github.com/kadirahq/react-komposer#change-the-loading-component)

I'll try something with the loading component and ref to the list (doc:https://github.com/kadirahq/react-komposer#ref-to-base-component)

This custom loading component receives all the props passed to the UI Component as well. So, based on those props, you can change the behaviour of the loading component also.

@xavxyz
Copy link
Author

xavxyz commented Oct 11, 2016

I guess it's not relevant anymore, closing this :octocat:

@xavxyz xavxyz closed this Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants