[wip] React Komposer instead of mixins #8
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a way to use react-komposer dynamically with DocumentContainer & ListContainer, tested it in practice on Nova.
After reading different issues & discussions, in order to fit more with the react way,I defined
component
as a required props, so there is now only one-way to "contain":<Container component={MyDumbComp} />
.I'm having some issues with the infinite scrolling, the whole list re-renders. I guess it's related to arunoda/react-komposer#2 & arunoda/react-komposer#4, maybe it'll be fixed with arunoda/react-komposer#99.
Any feedback welcomed 👍