Clicking 6 times on a 'sign in' button causes error on the client side

[dufia]

Exception in delivering result of invoking 'login': TypeError: Cannot read property 'setError' of undefined

How to reproduce the error:
$ meteor create test
$ meteor add useraccounts:core accounts-password useraccounts:unstyled
add {{> atForm}} into body (test.html)
run the app with $ meteor
type anything into Email and Password inputs, click 'sign in' 6 times

errors are in the console

[MichaelJCole]

From the client side:

meteor.js:880 Exception in delivering result of invoking 'login': TypeError: Cannot read property 'setError' of undefined
    at http://localhost:4000/packages/useraccounts_core.js?e3a764dbf634d8bf2a393797c0a82e9fadef2e7a:1426:46
    at Function._.each._.forEach (http://localhost:4000/packages/underscore.js?46eaedbdeb6e71c82af1b16f51c7da4127d6f285:157:22)
    at AT.submitCallback (http://localhost:4000/packages/useraccounts_core.js?e3a764dbf634d8bf2a393797c0a82e9fadef2e7a:1425:9)
    at http://localhost:4000/packages/useraccounts_core.js?e3a764dbf634d8bf2a393797c0a82e9fadef2e7a:1995:35
    at Accounts.callLoginMethod.userCallback (http://localhost:4000/packages/accounts-password.js?8eae27e32c4d1bc1194f7c6dd2aaed1e33a88499:89:21)
    at http://localhost:4000/packages/accounts-base.js?7dabd814506e384c709f8bf707377955f9814129:612:26
    at http://localhost:4000/packages/underscore.js?46eaedbdeb6e71c82af1b16f51c7da4127d6f285:794:19
    at loggedInAndDataReadyCallback (http://localhost:4000/packages/accounts-base.js?7dabd814506e384c709f8bf707377955f9814129:708:7)
    at null._callback (http://localhost:4000/packages/meteor.js?9730f4ff059088b3f7f14c0672d155218a1802d4:999:22)
    at _.extend._maybeInvokeCallback (http://localhost:4000/packages/ddp-client.js?250b63e6c919c5383a0511ee4efbf42bb70a650f:3500:12)

[tjramage]

Can confirm this is also an issue for me. I wonder if this is a side effect of some sort of failed login attempt limit in order to prevent brute force attacks...

[tjramage]

Hm, scratch that idea. Just noticed this: #526

[dufia]

I will need to check how it works with 1.3

[ilan-schemoul]

const verySensitive = ['ATResendVerificationEmail'];
DDPRateLimiter.addRule({ name: name => _.contains(verySensitive, name), type: 'method' }, 1, 10000);

I load it server side. I want to limit ResendVerificaitonEmail method but it throws the error Cannot read property 'setError' of undefined

[ilan-schemoul]

This is caused by this line

 _.each(error.details, function(error, fieldId) {
    AccountsTemplates.getField(fieldId).setError(error);
});     

It should be replaced by :

_.each(error.details, function(error, fieldId) {              
   if (fieldId && error) {                                               
       AccountsTemplates.getField(fieldId).setError(error);
   }
});     

[ilan-schemoul]

Actually I'm wondering, maybe @splendido knows or someone else, if I set a ratelimit for a useraccount method, how could I make it show a custom message. Because for now it shows absolutely no message when rate limit is hit so the best solution would I could catch errors and return a T9N version of the message otherwise showing the English message would be less worst than nothing.

[kwuite]

Merged Pull request from RomanBF, bumping version and pushing to atmosphere.