fix: various fixes and enhancements #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 12, 2024 10:12
Signed-off-by: Piotr Sokólski <piotr@themetavoice.xyz>
Signed-off-by: Piotr Sokólski <piotr@themetavoice.xyz>
sidroopdaska
approved these changes
Feb 12, 2024
Closed
| ).transpose( | ||
| 1, 2 | ||
| ) # (B, nh, T, hs) -> (B, T, nh, hs) | ||
|
|
||
| return y | ||
|
|
||
| def _fa2_attention(self, c_x: torch.Tensor) -> torch.Tensor: | ||
| def _vanilla_attn(self, c_x: torch.Tensor) -> torch.Tensor: |
There was a problem hiding this comment.
why do we need this for this PR? for context, this used to be used as a test, otherwise _torch_attn does the job?
| @@ -161,7 +166,7 @@ def _convert_audiodata_to_wav_path(audiodata, wav_tmp): | |||
| seed=1337, | |||
| device=device, | |||
| dtype=GlobalState.config.dtype, | |||
| compile=False, | |||
| compile=GlobalState.config.compile, | |||
There was a problem hiding this comment.
this will not work right now and cause recompilations at each time-steps
There was a problem hiding this comment.
it does not seem to do that for me
There was a problem hiding this comment.
did you try with vanilla kv-cache or flash decoding?
There was a problem hiding this comment.
also, we probably need to change the mode for torch.compile during inference to get the most out of it, and to use cuda graphs
| flash_attn_with_kvcache, | ||
| ) | ||
| except ImportError: | ||
| warnings.warn("flash_attn not installed, make sure to replace attention mechanism with torch_attn") |
There was a problem hiding this comment.
nit: improve warning by providing the change in command required instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables: