Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: anonymised telemetry to track usage patterns #131

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

sidroopdaska
Copy link
Member

No description provided.

Copy link
Member

@vatsalaggarwal vatsalaggarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

why are new formatting changes getting introduced? I think yours look right, but not sure how the current code got committed?

fam/llm/fast_inference.py Show resolved Hide resolved
fam/llm/finetune.py Outdated Show resolved Hide resolved
fam/telemetry/__init__.py Outdated Show resolved Hide resolved
fam/telemetry/posthog.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Copy link
Contributor

@lucapericlp lucapericlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just +1ing @vatsalaggarwal's other extra metrics

properties = {
**config,
**model_args,
"train": str(train),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd also be interesting to know:

  1. How much data (minutes ideal, row count ok) in datasets
  2. What % of the network is being finetuned - we're already somewhat tracking this via last_n_blocks_to_finetune being captured but wouldn't cover any custom logic changes - a quick sum of trainable params before finetuning starts vs their config settings would let us observe that custom network changes were made (interesting data point).
  3. Hardware being used

@lucapericlp lucapericlp self-requested a review April 16, 2024 17:00
lucapericlp
lucapericlp previously approved these changes Apr 16, 2024
@sidroopdaska sidroopdaska merged commit eebdcc6 into main Apr 17, 2024
2 checks passed
Copy link
Member

@vatsalaggarwal vatsalaggarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vatsalaggarwal vatsalaggarwal deleted the sidroopdaska/telemetry branch April 18, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants