Set the seed for regression tests inside the functions - #631
Closed
Luthaf wants to merge 3 commits into
Closed
Conversation
Setting them at the module level means they are set when pytest performs test discovery. If more tests are added, the regression tests will start with a different RNG state than expected and fail.
Luthaf
requested review from
DavideTisi,
abmazitov and
frostedoyster
as code owners
June 20, 2025 14:39
PicoCentauri
left a comment
PicoCentauri
left a comment
Contributor
There was a problem hiding this comment.
Test cleanup day. 🧹
The failing tests are related to huggingface. Maybe there is just something broken on their side...
Member
Author
I'm working on #580, and fixing whatever annoys me on the way! |
Member
Author
No, I think this is because I'm making a PR from a fork. I'll update the test code |
Contributor
|
Probably ! |
This was referenced Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting them at the module level means they are set when pytest performs test discovery. If more tests are added, the regression tests will start with a different RNG state than expected and fail.
Contributor (creator of pull-request) checklist
Documentation updated (for new features)?Issue referenced (for PRs that solve an issue)?Reviewer checklist
📚 Documentation preview 📚: https://metatrain--631.org.readthedocs.build/en/631/