Add abstract base class for Model and Trainer - #598
Merged
Conversation
Luthaf
requested review from
DavideTisi,
abmazitov and
frostedoyster
as code owners
May 21, 2025 17:32
Luthaf
force-pushed
the
model-trainer-base-classes
branch
from
May 22, 2025 09:36
be52f98 to
0fbf85b
Compare
PicoCentauri
left a comment
PicoCentauri
left a comment
Contributor
There was a problem hiding this comment.
Looks clean and is well reflecting our design. I think the base class will be useful for new architecture to be added!
PicoCentauri
approved these changes
May 27, 2025
These allow to both document and enforce what function a model and trainer must have to be compatible with metatrain
Luthaf
force-pushed
the
model-trainer-base-classes
branch
from
May 27, 2025 15:27
0fbf85b to
371fb4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These allow to both document and enforce what function a model and trainer must have to be compatible with metatrain
Contributor (creator of pull-request) checklist
Issue referenced (for PRs that solve an issue)?Reviewer checklist
📚 Documentation preview 📚: https://metatrain--598.org.readthedocs.build/en/598/