Skip to content

Implement new writable stream #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions lib/errors.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
'use strict';

class InvalidArgTypeError extends TypeError {
constructor(name, expected, actual) {
super(`The "${name}" argument must be one of type ${expected}. ` +
`Received type ${typeof(actual)}`);
this.code = 'ERR_INVALID_ARG_TYPE';
this.name += ` [${this.code}]`;
}
}

class StreamNullValuesError extends TypeError {
constructor() {
super('May not write null values to stream');
this.code = 'ERR_STREAM_NULL_VALUES';
this.name += ` [${this.code}]`;
}
}

class MethodsNotImplementedError extends Error {
constructor() {
super('_write() and _vritev() methods are not implemented');
this.code = 'ERR_METHOD_NOT_IMPLEMENTED';
this.name += ` [${this.code}]`;
}
}

class StreamDestroyedError extends Error {
constructor() {
super('Cannot call write after a stream was destroyed');
this.code = 'ERR_STREAM_DESTROYED';
this.name += ` [${this.code}]`;
}
}

class StreamWriteAfterEndError extends Error {
constructor() {
super('write after end');
this.code = 'ERR_STREAM_WRITE_AFTER_END';
this.name += ` [${this.code}]`;
}
}

class UnknownEncodingError extends TypeError {
constructor(encoding) {
super(`Unknown encoding ${encoding}`);
this.code = 'ERR_UNKNOWN_ENCODING';
this.name += ` [${this.code}]`;
}
}

class OutOfRangeError extends RangeError {
constructor(name, range, actual) {
super(`The value of ${name} is out of range. It must be ${range}. ` +
`Received ${actual}`);
this.code = 'ERR_OUT_OF_RANGE';
this.name += ` [${this.code}]`;
}
}
module.exports = {
OutOfRangeError,
InvalidArgTypeError,
StreamDestroyedError,
UnknownEncodingError,
StreamNullValuesError,
MethodsNotImplementedError,
StreamWriteAfterEndError,
};
146 changes: 146 additions & 0 deletions lib/fs-writable.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,146 @@
// Copyright Node.js contributors. All rights reserved.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to
// deal in the Software without restriction, including without limitation the
// rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
// sell copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
// IN THE SOFTWARE.

'use strict';

const fs = require('fs');

const { Writable } = require('./writable');

const {
InvalidArgTypeError,
OutOfRangeError
} = require('./errors');

const openSymbol = Symbol('open');
const errorSymbol = Symbol('error');
const closeStreamSymbol = Symbol('closeStream');

class WritableFileStream extends Writable {
constructor(path, {
fd = null,
start,
flags = 'w',
bufferSize,
mode = 0o666,
encoding = null,
autoClose = true,
} = {}) {
super({ bufferSize });

this.fd = fd;
this.path = path;

this.closed = false;
this.bytesWritten = 0;

this.autoClose = autoClose;

if (typeof path !== 'string') {
throw new InvalidArgTypeError('path', 'string', path);
}

if (start !== undefined) {
if (typeof start !== 'number') {
throw new InvalidArgTypeError('start', 'number', start);
}
if (start < 0) {
throw new OutOfRangeError('start', '>= 0', `{start: ${start}}`);
}

this.pos = start;
}

if (encoding) this.setDefaultEncoding(encoding);

if (this.fd === null) this[openSymbol](flags, mode);
}

[errorSymbol](error, callback) {
if (callback) callback(error);
if (this.autoClose) {
this.destroy(error);
} else {
this.emit('error', error);
this.emit('close');
}
}

[openSymbol](flags, mode) {
fs.open(this.path, flags, mode, (error, fd) => {
if (error) {
this[errorSymbol](error);
return;
}

this.fd = fd;
this.emit('open', fd);
});
}

[closeStreamSymbol](callback, err) {
fs.close(this.fd, (er) => {
er = er || err;
this.closed = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should set this.closed = true; before calling a callback so that the callback will see a correct state.

callback(er);
this.emit('close');
});
}

_write(data, callback) {
if (!Buffer.isBuffer(data)) {
const err = new InvalidArgTypeError('data', 'Buffer', data);
this.emit('error', err);
return;
}

if (this.fd === null) {
this.once('open', () => this._write(data, callback));
return;
}

fs.write(this.fd, data, 0, data.length, this.pos, (error, bytes) => {
if (error) {
this[errorSymbol](error, callback);
return;
}
this.bytesWritten += bytes;
callback();
});

if (this.pos !== undefined) this.pos += data.length;
}

_destroy(err, callback) {
if (this.fd === null) {
this.once('open', () => this[closeStreamSymbol](callback, err));
return;
}
this[closeStreamSymbol](callback, err);
this.fd = null;
}

_final(callback) {
if (this.autoClose) this.destroy();
callback();
}
}

module.exports = { WritableFileStream };
Loading