Add intToIp converter to network #360
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimon-durak
changed the title
tshemsedinov
requested changes
Dec 9, 2020
There was a problem hiding this comment.
Please sign your commits with PGP
See: https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/managing-commit-signature-verification
| @@ -8,6 +8,8 @@ and this project adheres to | |||
|
|
|||
| ## [Unreleased][unreleased] | |||
|
|
|||
| - add intToIp converter to network | |||
There was a problem hiding this comment.
Suggested change
| - add intToIp converter to network | |
| - Add `intToIp` converter to `network.js` |
Comment on lines
+5
to
+7
| // Convert IPv4 address from string form to number form | ||
| // Signature: IP_string | ||
| // IP_string - <string>, (optional), default: '127.0.0.1', IPv4 address in string form |
There was a problem hiding this comment.
Suggested change
| // Convert IPv4 address from string form to number form | |
| // Signature: IP_string | |
| // IP_string - <string>, (optional), default: '127.0.0.1', IPv4 address in string form | |
| // Convert IPv4 address from string form to number form | |
| // Signature: [ip] | |
| // ip - <string>, (optional), default: '127.0.0.1', IPv4 address in string form |
Comment on lines
+12
to
+14
| // Convert IPv4 address from number form to string form | ||
| // Signature: IP_number | ||
| // IP_number - <number>, (optional), default: 0, IPv4 address in number form |
There was a problem hiding this comment.
Suggested change
| // Convert IPv4 address from number form to string form | |
| // Signature: IP_number | |
| // IP_number - <number>, (optional), default: 0, IPv4 address in number form | |
| // Convert IPv4 address from number form to string form | |
| // Signature: [ip] | |
| // ip - <number>, (optional), default: 0, IPv4 address in number form |
Comment on lines
+16
to
+19
| const intToIp = (ipInt = 0) => | ||
| [ipInt >>> 24, (ipInt >> 16) & 255, (ipInt >> 8) & 255, ipInt & 255].join( | ||
| '.' | ||
| ); |
There was a problem hiding this comment.
I'd prefer to put 4 parts of address into 4 separate variables and concatenate them without creating array and call join
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run fmt)npm run docto regenerate documentation based on comments)Unreleasedheader in CHANGELOG.md