Allow to wrap iterator with Iterator #337
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only objects with Symbol.iterator property were supported. This makes our Iterator only check for .next function on `base` and only perform `toIterator` if called with `iter` function. This is a BREAKING CHANGE.
|
Also, while most (all?) Iterators follow the pattern of returning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only objects with Symbol.iterator property were supported.
This makes our Iterator only check for .next function on
baseand only perform
toIteratorif called withiterfunction.This is a BREAKING CHANGE.
npm run fmt)npm run docto regenerate documentation based on comments)Unreleasedheader in CHANGELOG.mdWill update docs and changelog when we reach consensus on this as there are multiple options here.