-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove Rust workspace #754
Conversation
Workflow |
Workflow |
Workflow |
Workflow |
Workflow |
Workflow |
…ndation/metaplex-program-library into chore/remove-rust-workspace
Workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, just had a question about a few things and obviously I wouldn't be aware of things that were missed (since they don't show in the diff).
My main concern is about all these code updates, but maybe they were needed due to some lib upgrades?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not crazy about putting so many unrelated changes in one PR but everything looks correct.
This PR removes Rust work spaces from the repo to decouple project dependencies from each other and make things more flexible. It also modifies and cleans up some tests in order to get CI to pass and makes some CI fixes and improvements.
The big change here regarding BPF tests is to replace the
../../target/deploy
folder with a customtest-programs
folder in the project root and add a build script that automates installing these dependent programs.