Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Rust workspace #754

Merged
merged 42 commits into from
Oct 3, 2022
Merged

Conversation

samuelvanderwaal
Copy link
Contributor

@samuelvanderwaal samuelvanderwaal commented Sep 21, 2022

This PR removes Rust work spaces from the repo to decouple project dependencies from each other and make things more flexible. It also modifies and cleans up some tests in order to get CI to pass and makes some CI fixes and improvements.

The big change here regarding BPF tests is to replace the ../../target/deploy folder with a custom test-programs folder in the project root and add a build script that automates installing these dependent programs.

@samuelvanderwaal samuelvanderwaal requested a review from a team as a code owner September 21, 2022 00:10
@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/3130916353.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/3131292846.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/3131477058.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/3131539028.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/3131912477.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/3132715667.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/3138078026.

Copy link
Contributor

@thlorenz thlorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, just had a question about a few things and obviously I wouldn't be aware of things that were missed (since they don't show in the diff).
My main concern is about all these code updates, but maybe they were needed due to some lib upgrades?

.github/actions/install-linux-build-deps/action.yml Outdated Show resolved Hide resolved
.github/workflows/integration-hydra.yml Outdated Show resolved Hide resolved
.github/workflows/program-auction-house.yml Outdated Show resolved Hide resolved
.github/workflows/program-auctioneer.yml Outdated Show resolved Hide resolved
.github/workflows/program-token-entangler.yml Outdated Show resolved Hide resolved
.github/workflows/program-token-metadata.yml Outdated Show resolved Hide resolved
auction-house/program/src/execute_sale/mod.rs Show resolved Hide resolved
auction-house/program/tests/execute_sale.rs Show resolved Hide resolved
fixed-price-sale/program/Cargo.toml Show resolved Hide resolved
thlorenz
thlorenz previously approved these changes Sep 29, 2022
Copy link
Contributor

@blockiosaurus blockiosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not crazy about putting so many unrelated changes in one PR but everything looks correct.

@samuelvanderwaal
Copy link
Contributor Author

I'm not crazy about putting so many unrelated changes in one PR but everything looks correct.

Understandable, but let me refer you to this diagram so you can understand my last couple weeks.

Untitled Diagram drawio

@samuelvanderwaal samuelvanderwaal merged commit f448a12 into master Oct 3, 2022
@samuelvanderwaal samuelvanderwaal deleted the chore/remove-rust-workspace branch October 3, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants