Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant check #1139

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Conversation

samuelvanderwaal
Copy link
Contributor

Removes a redundant check that is already present in Bubblegum. As long as this handler is permissioned to Bubblegum this check only needs to be in Bubblegum. This assertion is getting reworked in Bubblegum to support both delegate types and it's not necessary to add the extra code to this assert as well--better to remove it to save binary size.

@samuelvanderwaal samuelvanderwaal requested a review from a team as a code owner July 5, 2023 18:16
@samuelvanderwaal samuelvanderwaal requested review from lorisleiva, blockiosaurus and danenbm and removed request for a team and lorisleiva July 5, 2023 18:16
Copy link
Contributor

@danenbm danenbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@blockiosaurus blockiosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants