You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burning an edition decreases the supply, which breaks the way Fixed Price Sale currently calculates the next edition number. this PR uses the passed in edition marker and finds the first available edition on that particular marker. It has to figure out which edition marker is passed in, in order to determine the correct edition number, so must do a loop deriving the edition marker PDAs and comparing them against what is passed in. For large edition numbers this might use up available compute units.
In addition, it adds a buy_v2 that requires passing in the edition marker number in edition to the edition marker PDA. This allows a single derivation to be made to calculate the edition number, but would be a breaking change if applied to buy. Since the accounts are identical you continue to use the Buy account struct and only use the BuyV2 instruction struct for the additional argument. This allows reducing code duplication.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
samuelvanderwaal
changed the title
Burning an edition decreases the supply, which breaks the way Fixed Price Sale currently calculates the next edition number. this PR uses the passed in edition marker and finds the first available edition on that particular marker. It has to figure out which edition marker is passed in, in order to determine the correct edition number, so must do a loop deriving the edition marker PDAs and comparing them against what is passed in. For large edition numbers this might use up available compute units.
In addition, it adds a
buy_v2that requires passing in the edition marker number in edition to the edition marker PDA. This allows a single derivation to be made to calculate the edition number, but would be a breaking change if applied tobuy. Since the accounts are identical you continue to use theBuyaccount struct and only use theBuyV2instruction struct for the additional argument. This allows reducing code duplication.