Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding allowance for hydra owned member wallets. #1124

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Adding allowance for hydra owned member wallets. #1124

merged 2 commits into from
Jun 26, 2023

Conversation

blockiosaurus
Copy link
Contributor

Based on GlassEaters/hydra@1bd0b6d it seems like an oversight that the wallet check doesn't allowed hydra owned members in distribute, but does in add_member. Fixing this.

@blockiosaurus blockiosaurus requested review from nhanphan, a team, lorisleiva, svc01-metaplex, febo, samuelvanderwaal and danenbm and removed request for a team June 26, 2023 20:59
@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for hydra. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/5382940454.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for hydra. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/5382967117.

febo
febo approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blockiosaurus blockiosaurus merged commit bfa821e into master Jun 26, 2023
@blockiosaurus blockiosaurus deleted the keith/hydra/recursive-hydra branch June 26, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhanphan nhanphan nhanphan approved these changes

@febo febo febo approved these changes

@lorisleiva lorisleiva Awaiting requested review from lorisleiva lorisleiva was automatically assigned from metaplex-foundation/protocol

@svc01-metaplex svc01-metaplex Awaiting requested review from svc01-metaplex svc01-metaplex was automatically assigned from metaplex-foundation/protocol

@samuelvanderwaal samuelvanderwaal Awaiting requested review from samuelvanderwaal

@danenbm danenbm Awaiting requested review from danenbm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blockiosaurus @febo @nhanphan