Reverting new leaf schema events for burn, redeem, and decompress
#1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danenbm
changed the title
burn, redeem, and decompress
danenbm
requested review from
samuelvanderwaal and
blockiosaurus
and removed request for
a team
|
Workflow |
samuelvanderwaal
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was added to Bubblegum to make Read API indexing of compression easier. But instead of using these leaf schema events, we were able to derive the
asset_idusing the leaf index from the change log event.I think it would have been more convenient to use these leaf events, but by solving it through derivation in the Read API, it keeps the Read API backwards compatible with all existing cNFT transactions that don't provide the leaf schema events in
burn,redeem, anddecompress.Note this code was never deployed to devnet or mainnet.