Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove migrate instruction #1117

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Conversation

samuelvanderwaal
Copy link
Contributor

@samuelvanderwaal samuelvanderwaal commented Jun 15, 2023

Removes the migrate instruction and frees up 11,288 bytes of space. This is a permissioned handler used only for the temporary pNFT migration--there shouldn't be any external users of it.

@samuelvanderwaal samuelvanderwaal requested a review from a team as a code owner June 15, 2023 18:48
@samuelvanderwaal samuelvanderwaal requested review from danenbm and blockiosaurus and removed request for a team June 15, 2023 18:48
blockiosaurus
blockiosaurus previously approved these changes Jun 15, 2023
Copy link
Contributor

@blockiosaurus blockiosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, get it outta here!

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/5282500169.

Copy link
Contributor

@danenbm danenbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danenbm danenbm self-requested a review June 15, 2023 22:13
Copy link
Contributor

@danenbm danenbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to regenerate JS SDK

@samuelvanderwaal samuelvanderwaal merged commit 3d253df into master Jun 15, 2023
@samuelvanderwaal samuelvanderwaal deleted the refactor/remove-migration-command branch June 15, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants