Skip to content

[Feature]: upgrade fixed-price to spl-token v0.2.0 #297

Closed
@thlorenz

Description

Which package is this feature request for?

fixed-price-sale

Feature

The remaining part of mpl packages were upgraded to that new minor (which included breaking changes).

In order to by synced up and make upgrading deps repository wide easier fixed-price should have the same version of spl-token.
I took a stab at this on the thlorenz/chore/upgrade-spl-token+fixed-price branch but couldn't get all tests to pass.

The main problem seems to be that the market isn't properly initialized when operating on it, i.e. when executing a buy transaction in this test.

Namely of the tests the following files contain failing ones:

  • buy.test.ts
  • claimResource.test.ts
  • validate.test.ts
  • withdraw.test.ts

all seem to fail for the a similar reason, therefore it might be a fix in a single place that would fix it.

Standard Change?

No

Ideal solution or implementation

After trying for a while I left it stashed at the afore mentioned branch as tests on master already show timing issues which are attempted to fix via sleeps and I thus felt I might be dealing with timing issues here as well.
I hope the team that implemented this contract could continue where I left off and get those tests to pass.

Alternative solutions or implementations

No response

Other context

No response

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions