feat: create transaction fee estimator #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vladimir-Beliy
requested review from
aheckmann,
thlorenz,
kurpav and
b2kdaman
b2kdaman
previously approved these changes
Dec 17, 2021
kurpav
suggested changes
Dec 17, 2021
src/actions/estimateFee.ts
Outdated
| signers?: Keypair[]; | ||
| } | ||
|
|
||
| type EstimateFee = (params: Params) => Promise<number>; |
There was a problem hiding this comment.
I'd use BN for the returned transaction fee
And please leave a comment that you return fee in lamports
There was a problem hiding this comment.
Vladimir-Beliy
force-pushed
the
estimate_fee
branch
from
2de0db4
to
5140734
Compare
kurpav
approved these changes
Dec 28, 2021
|
@Vladimir-Beliy please export this action |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues/115
I think in the future we should use this method