feat: add Python implementation of accelerated OP #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
force-pushed
the
cross-platform
branch
from
381c658
to
42bbbd6
Compare
XuehaiPan
added
enhancement
Codecov ReportBase: 64.46% // Head: 63.57% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 64.46% 63.57% -0.89%
==========================================
Files 66 68 +2
Lines 2842 2883 +41
==========================================
+ Hits 1832 1833 +1
- Misses 1010 1050 +40
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
XuehaiPan
force-pushed
the
cross-platform
branch
from
57ad305
to
5e35102
Compare
XuehaiPan
force-pushed
the
cross-platform
branch
from
5e35102
to
abdb3db
Compare
XuehaiPan
force-pushed
the
cross-platform
branch
4 times, most recently
from
47ddf71
to
e4cc211
Compare
XuehaiPan
force-pushed
the
main
branch
2 times, most recently
from
eca7bdd
to
ac2f0db
Compare
XuehaiPan
force-pushed
the
cross-platform
branch
from
e4cc211
to
3da6046
Compare
XuehaiPan
force-pushed
the
cross-platform
branch
from
3da6046
to
ab55926
Compare
XuehaiPan
force-pushed
the
cross-platform
branch
2 times, most recently
from
a005547
to
42a6a80
Compare
XuehaiPan
force-pushed
the
cross-platform
branch
2 times, most recently
from
13828d6
to
4e0f36e
Compare
XuehaiPan
force-pushed
the
cross-platform
branch
2 times, most recently
from
84a2f9e
to
09946f1
Compare
XuehaiPan
force-pushed
the
cross-platform
branch
2 times, most recently
from
cd4cd7b
to
1183487
Compare
XuehaiPan
force-pushed
the
cross-platform
branch
from
1183487
to
f696543
Compare
XuehaiPan
force-pushed
the
cross-platform
branch
2 times, most recently
from
0aee719
to
e0c7e9c
Compare
XuehaiPan
force-pushed
the
cross-platform
branch
2 times, most recently
from
1da6716
to
4d30221
Compare
XuehaiPan
force-pushed
the
cross-platform
branch
from
4d30221
to
ecd4a43
Compare
JieRen98
reviewed
Nov 28, 2022
| dmu: torch.Tensor, updates: torch.Tensor, mu: torch.Tensor, b1: float | ||
| ) -> Tuple[torch.Tensor, torch.Tensor]: | ||
| """Adam backward mu.""" | ||
| dupdates = dmu.mul(1.0 - b1) |
There was a problem hiding this comment.
1.0 -> double or float or?
There was a problem hiding this comment.
It will be cast to the same floating point type as dmu.dtype, usually torch.float32.
XuehaiPan
force-pushed
the
cross-platform
branch
2 times, most recently
from
3cea69d
to
044ffd7
Compare
XuehaiPan
force-pushed
the
cross-platform
branch
from
044ffd7
to
8653f7b
Compare
XuehaiPan
force-pushed
the
cross-platform
branch
2 times, most recently
from
8888634
to
98915c2
Compare
XuehaiPan
force-pushed
the
cross-platform
branch
from
98915c2
to
75e8957
Compare
XuehaiPan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #36
Resolves #66
Motivation and Context
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format(required)make lint(required)make testpass. (required)