-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(treespec): memorize ongoing repr
/ hash
calls to resolve infinite recursion under self-referential case
#82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
added
bug
Something isn't working
cxx
Something related to the CXX source code
labels
Sep 23, 2023
XuehaiPan
force-pushed
the
infinite-self-reference
branch
2 times, most recently
from
September 24, 2023 05:29
a5d1a9c
to
741ee63
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 425 425
=========================================
Hits 425 425
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
XuehaiPan
force-pushed
the
infinite-self-reference
branch
from
September 24, 2023 06:25
d19f673
to
0beb6e6
Compare
…rsion under self-referential case
…rsion under self-referential case
XuehaiPan
force-pushed
the
infinite-self-reference
branch
from
September 24, 2023 06:31
0beb6e6
to
f7bb0ee
Compare
JieRen98
requested changes
Sep 24, 2023
Co-authored-by: Jie Ren <jieren9806@gmail.com>
JieRen98
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail.
Add a set to memorize ongoing
repr
/hash
calls to resolve infinite recursion under self-referential case.Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213
if this solves the issue #15213Fixes #81
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format
. (required)make lint
. (required)make test
pass. (required)