Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(treespec): memorize ongoing repr / hash calls to resolve infinite recursion under self-referential case #82

Merged
merged 8 commits into from
Sep 24, 2023

Conversation

XuehaiPan
Copy link
Member

Description

Describe your changes in detail.

Add a set to memorize ongoing repr / hash calls to resolve infinite recursion under self-referential case.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Fixes #81

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan added bug Something isn't working cxx Something related to the CXX source code labels Sep 23, 2023
@XuehaiPan XuehaiPan self-assigned this Sep 23, 2023
@XuehaiPan XuehaiPan force-pushed the infinite-self-reference branch 2 times, most recently from a5d1a9c to 741ee63 Compare September 24, 2023 05:29
@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c7c3dcd) 100.00% compared to head (916c6bd) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #82   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          425       425           
=========================================
  Hits           425       425           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

include/treespec.h Outdated Show resolved Hide resolved
src/treespec/treespec.cpp Outdated Show resolved Hide resolved
include/treespec.h Show resolved Hide resolved
@JieRen98 JieRen98 self-requested a review September 24, 2023 08:23
@XuehaiPan XuehaiPan merged commit fa52980 into metaopt:main Sep 24, 2023
38 checks passed
@XuehaiPan XuehaiPan deleted the infinite-self-reference branch September 24, 2023 10:35
@XuehaiPan XuehaiPan added this to the 0.10.0 milestone Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cxx Something related to the CXX source code
Projects
None yet
2 participants