Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registry): raise a warning when registering subclasses of namedtuple #24

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

XuehaiPan
Copy link
Member

Description

Describe your changes in detail.

Raise a UserWarning when registering subclasses of namedtuple. All subclasses of namedtuple are already registered. Users can override it with custom flatten/unflatten functions. We raise a warning here for the notice.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan self-assigned this Jan 30, 2023
@XuehaiPan XuehaiPan added enhancement New feature or request cxx Something related to the CXX source code labels Jan 30, 2023
@XuehaiPan XuehaiPan force-pushed the warn-namedtuple branch 3 times, most recently from 5768f1a to 157a12d Compare January 30, 2023 14:56
@XuehaiPan XuehaiPan merged commit 0dd262a into metaopt:main Jan 31, 2023
@XuehaiPan XuehaiPan deleted the warn-namedtuple branch January 31, 2023 04:16
@XuehaiPan XuehaiPan added this to the 0.6.0 milestone Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx Something related to the CXX source code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants