Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add clang-tidy integration #20

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Conversation

XuehaiPan
Copy link
Member

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Resolves #18
Closes #19

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • New feature (non-breaking change which adds core functionality)

Implemented Tasks

  • Add new targets to Makefile
  • Update the C++ source code accordingly.
  • Add new step in lint GitHub Actions.

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan self-assigned this Jan 23, 2023
@XuehaiPan XuehaiPan added enhancement New feature or request cxx Something related to the CXX source code labels Jan 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2023

Codecov Report

Base: 94.04% // Head: 94.04% // No change to project coverage 👍

Coverage data is based on head (9631589) compared to base (bd7a05a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files           4        4           
  Lines         319      319           
=======================================
  Hits          300      300           
  Misses         19       19           
Flag Coverage Δ
unittests 94.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@XuehaiPan
Copy link
Member Author

Hi @Skylion007, I add a new target in Makefile and update the source code accordingly. Could you have a look at this? Many thanks.

.clang-tidy Outdated Show resolved Hide resolved
@XuehaiPan XuehaiPan merged commit 4dac679 into metaopt:main Jan 24, 2023
@XuehaiPan XuehaiPan deleted the clang-tidy branch January 24, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx Something related to the CXX source code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Setup Clang-Tidy
4 participants