feat(src/utils): add cache to is_namedtuple and is_structseq
#121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
added
enhancement
XuehaiPan
commented
Jan 2, 2024
include/utils.h
Outdated
Comment on lines
528
to
549
| inline bool IsStructSequenceClass(const py::handle& type) { | ||
| return PyType_Check(type.ptr()) && IsStructSequenceClassImpl(type); | ||
| if (PyType_Check(type.ptr())) [[likely]] { | ||
| static auto cache = std::unordered_map<py::handle, bool, TypeHash, TypeEq>{}; | ||
| auto it = cache.find(type); | ||
| if (it != cache.end()) [[likely]] { | ||
| return it->second; | ||
| } | ||
| bool result = IsStructSequenceClassImpl(type); | ||
| cache.emplace(type, result); | ||
| (void)py::weakref(type, py::cpp_function([type](py::handle weakref) -> void { | ||
| cache.erase(type); | ||
| weakref.dec_ref(); | ||
| })) | ||
| .release(); | ||
| return result; | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Is this the best way to cache Python objects while cooperating with the Python GC? Could you have a look of this @Skylion007? Thanks!
XuehaiPan
force-pushed
the
cache-is-namedtuple-is-structseq
branch
2 times, most recently
from
54a7c56
to
8352ae9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 777 777
=========================================
Hits 777 777
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
XuehaiPan
force-pushed
the
cache-is-namedtuple-is-structseq
branch
3 times, most recently
from
10ef302
to
6f9c7d6
Compare
XuehaiPan
force-pushed
the
cache-is-namedtuple-is-structseq
branch
from
edd4ccf
to
f17d905
Compare
XuehaiPan
force-pushed
the
cache-is-namedtuple-is-structseq
branch
2 times, most recently
from
d24f48d
to
dd7e0cd
Compare
XuehaiPan
force-pushed
the
cache-is-namedtuple-is-structseq
branch
from
dd7e0cd
to
05f3825
Compare
XuehaiPan
force-pushed
the
cache-is-namedtuple-is-structseq
branch
from
314cd17
to
a42ad86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail.
Add a static cache in C++ to cache the result of
is_namedtupleandis_structseq. I got about 15% performance gain in the benchmark.Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format. (required)make lint. (required)make testpass. (required)