feat(ops): namespace support for custom node type registry #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
force-pushed
the
namespace
branch
3 times, most recently
from
bf1cf1c
to
4e5116f
Compare
Codecov ReportBase: 92.93% // Head: 93.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 92.93% 93.91% +0.97%
==========================================
Files 4 4
Lines 269 312 +43
==========================================
+ Hits 250 293 +43
Misses 19 19
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
XuehaiPan
force-pushed
the
namespace
branch
2 times, most recently
from
cba7b14
to
7b974bb
Compare
XuehaiPan
changed the title
XuehaiPan
force-pushed
the
namespace
branch
10 times, most recently
from
7113e3f
to
0f88fc4
Compare
XuehaiPan
force-pushed
the
namespace
branch
4 times, most recently
from
61aaaa4
to
66a6df1
Compare
JieRen98
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213Add namespace isolation for custom node type registry.
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format. (required)make lint. (required)make testpass. (required)