Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: cache intermediate str objects in PyObject_GetAttr calls #106

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

XuehaiPan
Copy link
Member

Description

Describe your changes in detail.

Cache constant intermediate str objects in PyObject_GetAttr calls. This change will get approximately 20% performance gain in the benchmark script.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan added the cxx Something related to the CXX source code label Nov 18, 2023
@XuehaiPan XuehaiPan self-assigned this Nov 18, 2023
@XuehaiPan XuehaiPan changed the title pref: cache intermediate str objects in PyObject_GetAttr pref: cache intermediate str objects in PyObject_GetAttr calls Nov 18, 2023
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0bfc0e0) to head (419eae1).
Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #106   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          708       708           
=========================================
  Hits           708       708           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XuehaiPan XuehaiPan changed the title pref: cache intermediate str objects in PyObject_GetAttr calls perf: cache intermediate str objects in PyObject_GetAttr calls Nov 18, 2023
@XuehaiPan XuehaiPan force-pushed the string-cache branch 12 times, most recently from ae1dd4e to 6857172 Compare November 19, 2023 21:19
@XuehaiPan XuehaiPan merged commit b4c0c11 into metaopt:main Nov 20, 2023
43 checks passed
@XuehaiPan XuehaiPan deleted the string-cache branch November 20, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx Something related to the CXX source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant