Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integration): add tree_ravel functions #100

Merged
merged 17 commits into from
Nov 7, 2023

Conversation

XuehaiPan
Copy link
Member

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Resolves #96

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan added enhancement New feature or request py Something related to the Python source code integration Integration for other packages labels Nov 5, 2023
@XuehaiPan XuehaiPan added this to the 0.10.0 milestone Nov 5, 2023
@XuehaiPan XuehaiPan self-assigned this Nov 5, 2023
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8e33b68) to head (604104d).
Report is 58 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #100    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            4         8     +4     
  Lines          515       708   +193     
==========================================
+ Hits           515       708   +193     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XuehaiPan XuehaiPan force-pushed the integration branch 6 times, most recently from e72193c to ff2e3dd Compare November 5, 2023 13:10
@XuehaiPan XuehaiPan force-pushed the integration branch 7 times, most recently from 0517c7d to 117a193 Compare November 5, 2023 14:51
@XuehaiPan XuehaiPan force-pushed the integration branch 3 times, most recently from 55cae68 to d015c50 Compare November 5, 2023 15:07
@XuehaiPan XuehaiPan marked this pull request as ready for review November 5, 2023 16:45
@XuehaiPan XuehaiPan merged commit 6c34a89 into metaopt:main Nov 7, 2023
43 checks passed
@XuehaiPan XuehaiPan deleted the integration branch November 7, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request integration Integration for other packages py Something related to the Python source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Implement optree.ravel_pytree similar to from jax.flatten_util import ravel_pytree
1 participant