Skip to content

Conversation

manuelfuenmayor
Copy link

Fixes #26

@manuelfuenmayor manuelfuenmayor changed the title [WIP] Update rfc-asciidoc-rfc document to v3 Update rfc-asciidoc-rfc document to v3 Aug 9, 2024
@manuelfuenmayor
Copy link
Author

@ronaldtse I think this one is ready to merge.

@manuelfuenmayor
Copy link
Author

Perhaps the reason some tests are failing is because there are fixed bugs that have not been included yet.

Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manuelfuenmayor there may be some misunderstanding with the included code snippets. The code snippets are meant to be rendered, the “tags” are used to filter out what is rendered.

@manuelfuenmayor
Copy link
Author

manuelfuenmayor commented Aug 11, 2024

@manuelfuenmayor there may be some misunderstanding with the included code snippets. The code snippets are meant to be rendered, the “tags” are used to filter out what is rendered.

@ronaldtse I thought that the include:: directives weren't meant to be rendered because many paths don't actually exist. Basically, the paths pointing to xml3 and xml2 folders.

For example,

<CODE BEGINS>
include::../examples/rfc-asciirfc-minimal/xml3/draft-asciirfc-minimal.xml[]
<CODE ENDS>

rfc-asciirfc-minimal/ is a submodule that does not contain a xml3/ folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update this document to use Metanorma instead of the old asciidoctor-rfc

2 participants