Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable 'redfish-uefihttp' as a vm_driver_tmp #1457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable 'redfish-uefihttp' as a vm_driver_tmp #1457

wants to merge 1 commit into from

Conversation

derekhiggins
Copy link
Member

Enable driver to boot VM's with 'BootSourceOverrideTarget': 'UefiHttp'

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mboukhalfa for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 12, 2024
@derekhiggins derekhiggins mentioned this pull request Sep 12, 2024
Merged
hroyrh
hroyrh reviewed Sep 12, 2024
View reviewed changes
vm-setup/roles/libvirt/templates/ironic_nodes.json.j2
@@ -45,6 +45,9 @@
{% elif vm_driver_tmp == 'redfish-virtualmedia' -%}
"port": "8000",
"address": "{{vm_driver_tmp}}+http://{{ lvars['host_ip'] | ipwrap }}:8000/redfish/v1/Systems/{{vm_id[node.name]}}",
{% elif vm_driver_tmp == 'redfish-https' -%}
"port": "8000",
"address": "{{vm_driver_tmp}}+http://{{ lvars['host_ip'] | ipwrap }}:8000/redfish/v1/Systems/{{vm_id[node.name]}}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be {{vm_driver_tmp}}+https:// ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No the http reference here is what metal3-dev-env sets up with sushy-tools
On a real environment with real baremetal then https would be used

tuminoid
tuminoid reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign-off the commit to pass DCO.

@tuminoid
Copy link
Member

/cc @Rozzii
Note the naming discussion, the counterpart was already merged with redfish-https.

@derekhiggins
Copy link
Member Author

/hold
waiting for feedback on comment on BMO PR
metal3-io/baremetal-operator#1954 (comment)

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2024
@derekhiggins
Enable 'redfish-https' as a vm_driver_tmp
0154da5 
Enable driver to boot VM's with 'BootSourceOverrideTarget': 'UefiHttp'

Signed-off-by: Derek Higgins <derekh@redhat.com>
@derekhiggins
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2024
@tuminoid
Copy link
Member

tuminoid commented Sep 20, 2024 •
edited
Loading

Should we update PR title to say redfish-uefihttp ?

@Rozzii
Copy link
Member

Rozzii commented Sep 23, 2024

Should we update PR title to say redfish-uefihttp ?

Why can I edit your comment? (Rozzi)

Yes!

@Rozzii Rozzii changed the title Enable 'redfish-https' as a vm_driver_tmp Enable 'redfish-uefihttps' as a vm_driver_tmp Sep 23, 2024
@Rozzii Rozzii changed the title Enable 'redfish-uefihttps' as a vm_driver_tmp Enable 'redfish-uefihttp' as a vm_driver_tmp Sep 23, 2024
@Rozzii
Copy link
Member

Rozzii commented Oct 7, 2024

/test metal3-centos-e2e-integration-test-release-1-8
/test metal3-dev-env-integration-test-ubuntu-main
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2024
Rozzii
Rozzii reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2024
@metal3-io-bot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Rozzii left review comments

@hroyrh hroyrh hroyrh left review comments

@tuminoid tuminoid tuminoid left review comments

@Sunnatillo Sunnatillo Awaiting requested review from Sunnatillo

Assignees
No one assigned
Labels
lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@derekhiggins @metal3-io-bot @tuminoid @Rozzii @hroyrh