-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge ironic and ironic-inspector repositories, single Dockerfile #253
Conversation
/test-integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this path, just a couple of comments inline.
a489b68
to
a5390f5
Compare
/assign @fmuyassarov |
a5390f5
to
1e4d938
Compare
/test-integration |
1e4d938
to
d37eac1
Compare
This change moves Dockerfile, configuration and scripts from the ironic-inspector container image repository to the ironic one. This approach provides one Dockerfile that builds an image that contains all the services necessary to run both ironic and ironic-inspector. The scripts and configurations are kept separated for the time being as some of them conflict with each other (e.g. runhttpd) and are being renamed to avoid overwriting during the image building process. Those changes will need to be reflected in CI as well.
d37eac1
to
618d44c
Compare
/test-integration |
Thanks @fmuyassarov ! |
Yeah, I think metal3-dev-env changes can be done later too, because we will still have image for ironic-inspector in quay, so that won't really break the CI. |
After ironic-inspector merges with ironic image, we need to change the reference of the ironic-inspector container to point to the ironic image in quay. This should happen after metal3-io/ironic-image#253
After ironic-inspector merges with ironic image, we need to change the reference of the ironic-inspector container to point to the ironic image in quay. This should happen after metal3-io/ironic-image#253
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\o/
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After ironic-inspector merges with ironic image, we need to change the reference of the ironic-inspector container to point to the ironic image in quay. This should happen after metal3-io/ironic-image#253
After ironic-inspector merges with ironic image, we need to change the reference of the ironic-inspector container to point to the ironic image in quay. This should happen after metal3-io/ironic-image#253
@maelk @fmuyassarov @hardys can you please have another look at this? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this LGTM. We will probably need to force merge this one too, considering tide isn't in place at this moment.
@fmuyassarov thanks! As clarified on our chat, I'm totally ok waiting for tide to be back before we merge this. |
/lgtm Tide is back? |
It was for a while when I was testing. Still there are some minor things to setup :) but hopefully by Monday will be up. |
@elfosardo @dtantsur Prow is back on track. Probably |
/lgtm pretty please |
After ironic-inspector merges with ironic image, we need to change the reference of the ironic-inspector container to point to the ironic image in quay. This should happen after metal3-io/ironic-image#253
After ironic-inspector merges with ironic image, we need to change the reference of the ironic-inspector container to point to the ironic image in quay. This should happen after metal3-io/ironic-image#253
After ironic-inspector merges with ironic image, we need to change the reference of the ironic-inspector container to point to the ironic image in quay. This should happen after metal3-io/ironic-image#253
After ironic-inspector merges with ironic image, we need to change the reference of the ironic-inspector container to point to the ironic image in quay. This should happen after metal3-io/ironic-image#253
After ironic-inspector merges with ironic image, we need to change the reference of the ironic-inspector container to point to the ironic image in quay. This should happen after metal3-io/ironic-image#253 (cherry picked from commit 99fc4ae)
After ironic-inspector merges with ironic image, we need to change the reference of the ironic-inspector container to point to the ironic image in quay. This should happen after metal3-io/ironic-image#253
After ironic-inspector merges with ironic image, we need to change the reference of the ironic-inspector container to point to the ironic image in quay. This should happen after metal3-io/ironic-image#253
This change moves Dockerfile, configuration and scripts from the
ironic-inspector container image repository to the ironic one.
This approach provides one Dockerfile that builds an image that contains
all the services necessary to run both ironic and ironic-inspector.
The scripts and configurations are kept separated for the time being as
some of them conflict with each other (e.g. runhttpd) and are being
renamed to avoid overwriting during the image building process.
Those changes will need to be reflected in CI as well.
This change is mutually exclusive with #252