Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding BIOS Parameters in api.md #920

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Conversation

zouy414
Copy link
Member

@zouy414 zouy414 commented Jun 18, 2021

Signed-off-by: Zou Yu zouy.fnst@cn.fujitsu.com

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 18, 2021
@zouy414
Copy link
Member Author

zouy414 commented Jun 18, 2021

@andfasano @zaneb

@andfasano
Copy link
Member

andfasano commented Jun 18, 2021

Thanks @Hellcatlk
/lgtm

@zouy414
Copy link
Member Author

zouy414 commented Jun 21, 2021

/test-integration

@zaneb
Copy link
Member

zaneb commented Jun 21, 2021

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2021
Signed-off-by: Zou Yu <zouy.fnst@cn.fujitsu.com>
docs/api.md Outdated
@@ -182,6 +182,24 @@ The sub-fields are:
GiB. If unspecified or set to 0, the maximum capacity of disk will be
used for logical disk.

#### bios
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's called firmware, not bios

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

@dtantsur
Copy link
Member

/test-integration
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021
@zouy414
Copy link
Member Author

zouy414 commented Jun 23, 2021

/retest

@metal3-io-bot metal3-io-bot merged commit 647504c into metal3-io:master Jun 23, 2021
@zouy414 zouy414 deleted the api branch July 19, 2021 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants