Don't deprovision provisioned host due to error #916
Conversation
metal3-io-bot
added
the
size/XS
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hardys The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
Adding a test to cover this would be good, but otherwise lgtm, thanks! |
During provisioning, we want an error to cause the Host to be deprovisioned again, but we very much do not want that to happen when the Host is already provisioned. Due to an error in 0a7713b, provisioned Hosts were being automatically deprovisioned whenever an error (other than a registration error) occurred. In practice this only manifested on Adopt() failures, since we don't yet report power management failures. Fixes metal3-io#915
zaneb
force-pushed
the
provisioning-cancel-error
branch
from
318850a to
c15f0d8
Compare
metal3-io-bot
added
size/M
|
Added a test. |
|
/lgtm |
|
@sadasu: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
During provisioning, we want an error to cause the Host to be
deprovisioned again, but we very much do not want that to happen when
the Host is already provisioned. Due to an error in
0a7713b, provisioned Hosts were being
automatically deprovisioned whenever an error (other than a registration
error) occurred.
In practice this only manifested on Adopt() failures, since we don't yet
report power management failures.
Fixes #915