Support deploy_iso in addition to deploy_kernel/ramdisk #907
Conversation
metal3-io-bot
added
the
size/S
|
/test-integration |
|
Q: do we expect the ISO-only option to work with all drivers (in the foreseeable future), or just virtualmedia ones? |
Only virtual media for the foreseeable future. So we'll need to keep kernel/ramdisk support for machines that don't have virtual media. |
Redfish virtual media supports pre-generated ISO ramdisks in addition to a kernel/initramfs pair. Other drivers will catch up as well once https://storyboard.openstack.org/#!/story/2008880 is fixed.
metal3-io-bot
added
size/L
|
/test-integration |
But to clarify - Ironic does support iPXE boot of the ISO image, we just know that doesn't currently work with the iso images we're working with? I got reports of someone trying to boot a RHEL ISO with |
Ironic supports iPXE live ISO boot. We're not planning on supporting booting IPA ISOs via iPXE at the moment. |
| } | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
Nice, definitely clearer now, thanks!
(I understand that the fact that this part was into an init() block didn't help for testing, hope sooner or later we will refactor it)
There was a problem hiding this comment.
Moved this to the top of my list: #914
| return errors.New("Either DEPLOY_KERNEL_URL and DEPLOY_RAMDISK_URL or DEPLOY_ISO_URL must be set") | ||
| } | ||
| if (deployKernelURL == "" && deployRamdiskURL != "") || (deployKernelURL != "" && deployRamdiskURL == "") { | ||
| return errors.New("DEPLOY_KERNEL_URL and DEPLOY_RAMDISK_URL can only be set together") |
There was a problem hiding this comment.
Ok, my personal inclination would be to specify exactly which expected vars were not set (without forcing the user to look at the current container configuration, especially useful when you have just the logs), but it's anyhow an improvement and don't consider it blocking
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, elfosardo, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
This allows local testing of the BMO functionality added via metal3-io/baremetal-operator#907
This allows local testing of the BMO functionality added via metal3-io/baremetal-operator#907
Redfish virtual media supports pre-generated ISO ramdisks in addition
to a kernel/initramfs pair. Other drivers will catch up as well once
https://storyboard.openstack.org/#!/story/2008880 is fixed.