Add missing RBAC for secrets and events #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/M
kashifest
force-pushed
the
fix/rbac-secret
branch
from
62a0e64 to
7d1178b
Compare
maelk
approved these changes
Oct 9, 2020
metal3-io-bot
added
the
approved
dhellmann
reviewed
Oct 9, 2020
| @@ -82,6 +82,8 @@ func (info *reconcileInfo) publishEvent(reason, message string) { | |||
|
|
|||
| // +kubebuilder:rbac:groups=metal3.io,resources=baremetalhosts,verbs=get;list;watch;create;update;patch;delete | |||
| // +kubebuilder:rbac:groups=metal3.io,resources=baremetalhosts/status,verbs=get;update;patch | |||
| // +kubebuilder:rbac:groups="",resources=secrets,verbs=get;list;watch;update | |||
| // +kubebuilder:rbac:groups="",resources=events,verbs=get;list;watch;create;update;patch | |||
There was a problem hiding this comment.
I suspect that we don't need watch or patch here, but since this is blocking other work let's go ahead and merge this as-is and see if we can shrink the list later.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, kashifest, maelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The missing RBAC rules were blocking CI, so I've merged this by hand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing RBAC rules for secrets and events