RAID Controller (StorageController) support; Marvell CLI (mvcli)

[splaspood]

What does this PR do

Fleshes out RAID controller support, specifically for Marvell RAID controllers.

The HW vendor this change applies to (if applicable)

Marvell

The HW model number, product name this change applies to (if applicable)

Marvell RAID controllers, generally. Specifically the: 88SE9230 PCIe 2.0 x2 4-port SATA 6 Gb/s RAID Controller

The BMC firmware and/or BIOS versions that this change applies to (if applicable)

N/A

What version of tooling - vendor specific or opensource does this change depend on (if applicable)

mvcli (mvcli-4.1.13.31_A01 was used during development testing)

How can this change be tested by a PR reviewer?

Description for changelog/release notes

• StorageController extended to support RAID controller specific bits
• actions.CreateVirtualDisk and actions.DestroyVirtualDisk interfaces

[joelrebel]

@splaspood if you rebase this branch on main, the linting should go through.

[joelrebel]

Thanks for the work here, looks pretty good overall 🚀

Could you add some examples for vdisk create, delete in https://github.com/metal-toolbox/ironlib/tree/main/examples

I've left a few change suggestions.

[joelrebel]

suggestion: implement the error interface and expose a single error type that wraps the others. If this seems to increase the number of lines of code instead of reducing it, feel free to ignore the suggestion.

This this can be done as such,

type StorageControllerError{
  stdout string
}

// implements the Error interface
func (s *StorageController) Error() string {
   return s.stdout
}

// constructor
func newStorageControllerError(stdout string) *StorageControllerError {
  return &StorageControllerError{stdout: stdout}
}

It can then be invoked as

if _, ok := validRaidModes[raidMode]; !ok {
  errRaidMode := newStorageControllerError(
        fmt.Sprintf("InvalidRaidMode %w : %v", ErrInvalidRaidMode, raidMode)
   )
  return nil, errors.Wrap(errRaidMode, ErrInvalidRaidMode.Error())
}

For end users, it may be easier to deal with one error type that wraps all of the other errors declared above,

// its easier to test for one type of error instead of the various ones above
if errors.Is(err, ErrStorageController) {

}

[joelrebel]

LGTM, thanks again for all the work here and squashing the commits!