Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ioutil and errors, update dependencies #201

Closed
wants to merge 4 commits into from
Closed

remove ioutil and errors, update dependencies #201

wants to merge 4 commits into from

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Jul 12, 2021 •
edited
Loading

  • replace ioutil with newer funcs
  • replace old errors
  • update dependencies
  • test new metal-stack/security

TODO:

  • test in test environment

@majst01 majst01 requested a review from Gerrit91 July 12, 2021 14:52
@majst01 majst01 marked this pull request as draft July 12, 2021 14:59
@Gerrit91
Copy link
Contributor

Maybe needs protoc generation with 1.27.1?

metal-stack/builder#27

@majst01 majst01 marked this pull request as ready for review July 15, 2021 08:35
@majst01
Copy link
Contributor Author

majst01 commented Jul 15, 2021

i keep it running in test for a day or two before merging

@majst01
Copy link
Contributor Author

majst01 commented Jul 21, 2021

already included in #202

@majst01 majst01 closed this Jul 21, 2021
@majst01 majst01 deleted the update-ioutil-and-errors branch July 21, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerrit91 Gerrit91 Gerrit91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@majst01 @Gerrit91