Open
Conversation
proffapt
reviewed
Jun 15, 2024
manifest.json
Outdated
| }, | ||
| "browser_specific_settings": { | ||
| "gecko": { | ||
| "id": "test@test.com", |
Member
There was a problem hiding this comment.
Does this work for chrome as well?
Author
There was a problem hiding this comment.
tab_func.js is working fine on both browsers. still should be tested on an actual CV to be sure
Member
There was a problem hiding this comment.
What is this? should it be committed?
Author
There was a problem hiding this comment.
It is needed to standardize the API for both chromium and non-chromium
proffapt
approved these changes
Jun 17, 2024
Member
proffapt
left a comment
proffapt
left a comment
There was a problem hiding this comment.
Let's wait till CV portal opens and we will try it out then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2