Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"draggable: false" with "prevNextButtons: true" triggers "next()" two times #721

Closed
tristantbg opened this issue Mar 20, 2018 · 4 comments
Closed

"draggable: false" with "prevNextButtons: true" triggers "next()" two times #721

tristantbg opened this issue Mar 20, 2018 · 4 comments
Labels
bug

Comments

@tristantbg
Copy link

Can be seen in the official Codepen :
https://codepen.io/desandro/pen/dPdoRO

Is it linked to accessibility or the new staticClick event triggered event on non draggable sliders ?
@tristantbg
Copy link
Author

Also, the keyboard "accessibility: true" doesn't work either.

Thank you.

@desandro desandro added the bug label Mar 20, 2018
@desandro
Copy link
Member

Thanks for reporting this bug. This looks to a bug in Chrome, but not Firefox or Safari. I'll take a look.

@bhushanscholastic
Copy link

bhushanscholastic commented Mar 22, 2018 •
edited
Loading

We are seeing the similar issue on IE and Chrome. Do we know when this will be fixed?

Is there any other option to make draggable: false? . We do not want to turn on the draggable to resolve this issue.

desandro added a commit that referenced this issue Mar 29, 2018
@desandro
🐞 fix double next() triggering when draggable disabled. #721
8cea63a 
🛠 add event argument for prevNext onTap
desandro added a commit that referenced this issue Mar 29, 2018
@desandro
👷 build v2.1.1
3f5b5fb 
👷 build v2.1.1

🐞 Fixed undefined _dragPointerMove bug with Unidragger 2.3. #724
🐞 Fixed double next on next button click. #721
🛠 **Breaking change** Removed vendor prefixes. Drop Android 4 support
@desandro
Copy link
Member

🎉 Flickity v2.1.1 has been released with a fix for this bug 🎉

Please update and report back if you still are running into issues.

@desandro desandro closed this as completed Apr 3, 2018
@snyk-bot snyk-bot mentioned this issue Mar 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
3 participants
@desandro @tristantbg @bhushanscholastic