Skip to content

Add extensions landing page #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Dec 14, 2020
Merged

Add extensions landing page #3

merged 29 commits into from
Dec 14, 2020

Conversation

katauber
Copy link
Member

Add a landing page for extensions with minimal tutorials for each extension.
Will resolve #2

katauber added 15 commits December 9, 2020 11:35
@katauber
Add first headings to structure landing page and add extension setup.
000cd58 
#2
@katauber
Add overview content.
eb04de1 
#2
@katauber
Ignore extensions/index.html.
d8e587b 
#2
@katauber
Add usage of GitHub Actions to generate extensions/index.html.
dcf17bd 
#2
@katauber
Refactor index.md.
ef2c995 
#2
@katauber
Checkout repository before generate hmtl.
c60f790 
#2
@katauber
Refactor pandoc args in GitHub Actions.
52d2017 
#2
@katauber
Start description of how to use the extensions.
8fe502e 
#2
@katauber
Add commit of generated extensions/index.html.
73ef26e 
#2
@katauber
Add force commit in GitHub Actions.
c6cbd15 
#2
@katauber
Add newly generated extensions/index.html by GitHub Actions.
91015d9
@katauber
Add initial README.
d6efd71 
#2
@katauber
Add minimal tutorials for Fix and Flux extensions.
7444fca 
#2
@katauber
Merge branch '2-extensions-landing-page' of github.com:metafacture/me…
640abf3 
…tafacture.github.io into 2-extensions-landing-page
@katauber
Add newly generated extensions/index.html by GitHub Actions.
4463d7d
@katauber katauber requested a review from fsteeg December 10, 2020 15:18
@fsteeg
Copy link
Member

fsteeg commented Dec 11, 2020

Thanks, looks good already. Did some text tweaks, switched to using HTML image tags (and tweaked how the images are displayed), and added a Metafacture header image. Have a look at 1825a5d to see if these look good to you. Other than that, I noticed:

  • The first image has an error in the editor
  • First and second image have different coloring for strings
  • With a collapsed side bar on the left side we'd focus more on the Fix/Flux file

@fsteeg fsteeg assigned katauber and unassigned fsteeg Dec 11, 2020
@katauber
Copy link
Member Author

Thank you for your feedback. I fixed the images of the fix and flux files.
I am not really happy anymore having extensions/index.html in gitignore: gitignore has no effect because the file is added to the repository by GitHub Actions. Any ideas how to handle this?

@katauber katauber assigned fsteeg and unassigned katauber Dec 14, 2020
fsteeg
fsteeg approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@fsteeg fsteeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, did one minor change: added links to published locations in README.

To proceed, I suggest you merge this and then reopen and assign #2 to Adrian for review.

@fsteeg fsteeg assigned katauber and unassigned fsteeg Dec 14, 2020
@katauber katauber merged commit 1f52560 into main Dec 14, 2020
@katauber katauber deleted the 2-extensions-landing-page branch December 14, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsteeg fsteeg fsteeg approved these changes

Assignees

@katauber katauber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up /extensions landing page
2 participants
@katauber @fsteeg