Skip to content

Add workflow badge "Build and Deploy" #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dr0i merged 2 commits into from
Jan 18, 2021
Merged

Add workflow badge "Build and Deploy" #11

dr0i merged 2 commits into from
Jan 18, 2021

Conversation

@dr0i
Copy link
Member

@dr0i dr0i commented Jan 14, 2021

Complements #7.

@dr0i dr0i requested a review from katauber January 14, 2021 16:03
@dr0i dr0i self-assigned this Jan 14, 2021
@dr0i dr0i added the documentation Improvements or additions to documentation label Jan 14, 2021
@dr0i
Copy link
Member Author

dr0i commented Jan 14, 2021

As in metafacture/metafacture-fix#44, I am not sure if this is the proper badge, because there are two workflows:

  1. Build and Deploy
  2. Build

While this PR covers 1 it obviously does not 2 - because this PR doesn't show up at 1 but only at 2.

@dr0i
Copy link
Member Author

dr0i commented Jan 15, 2021

Ah, I see: Build builds on every push, regardless of the name of the branch.
Build and Deploy does run only when pushing into the master (aka main) branch.
We may need then two badges, right?

@dr0i dr0i mentioned this pull request Jan 15, 2021
Merged
@dr0i
Copy link
Member Author

dr0i commented Jan 15, 2021

As in metafacture/metafacture-fix#44 (comment):

On a second thought: it's a badge at the README and we want to reflect the status of the main/master branch there. No second badge is needed.

katauber
katauber reviewed Jan 18, 2021
View reviewed changes
Copy link
Member

@katauber katauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for correcting.

@dr0i dr0i merged commit 43c515a into main Jan 18, 2021
@dr0i
Copy link
Member Author

dr0i commented Jan 18, 2021

Deployed, closed.

@dr0i dr0i deleted the addBadge branch January 18, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@katauber katauber katauber left review comments

Assignees

@dr0i dr0i

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dr0i @katauber