Added fallbacks to flux.sh in case realpath is not available #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bash script now uses $BASH_SOURCE to find out its name. If `realpath` is not available `readlink` is tried. If this is not available the script attempts to extract link targets from ls output. Link resolution is now only attempted if $BASH_SOURCE contains a soft link.
blackwinter
added a commit
that referenced
this pull request
Dec 13, 2024
Introduce `@MetafixToDo` annotation to mark tests as disabled.
blackwinter
added a commit
that referenced
this pull request
Dec 13, 2024
Set `org.metafacture.metafix.disableToDo=true` to mimic previous `@Disabled` behaviour.
blackwinter
added a commit
that referenced
this pull request
Dec 13, 2024
blackwinter
added a commit
that referenced
this pull request
Dec 13, 2024
Similar to previous `disabled.txt`, but ensures that fixed integration tests don't stay disabled. Failing tests marked as "to do" will be reported as *skipped*; passing tests marked as "to do" will be reported as *failed*. Set environment variable `METAFIX_DISABLE_TO_DO=true` (or system property `org.metafacture.metafix.disableToDo=true` when run via Gradle) to mimic previous `disabled.txt` behaviour. Analogous to `@MetafixToDo` annotation in unit tests (see #158 and f4a7523).
blackwinter
added a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bash script now uses $BASH_SOURCE to find out its name. If
realpathis not availablereadlinkis tried. If this is notavailable the script attempts to extract link targets from ls
output. Link resolution is now only attempted if $BASH_SOURCE
contains a soft link.
This fixes issue #144